fix: ensure smart accounts are deployed before validating signatures #5092
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
🦋 Changeset detectedLatest commit: e0134c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
joaquim-verges
changed the title
joaquim-verges
force-pushed
the
test_enable_SmartWallet_policy_tests
branch
from
cd1214c to
c6621dc
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5092 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 1059 1059
Lines 54729 54754 +25
Branches 3956 3958 +2
=======================================
+ Hits 24789 24803 +14
- Misses 29249 29260 +11
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
force-pushed
the
test_enable_SmartWallet_policy_tests
branch
from
c6621dc to
8b5f01c
Compare
joaquim-verges
force-pushed
the
test_enable_SmartWallet_policy_tests
branch
from
8b5f01c to
e0134c6
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on ensuring that smart accounts are deployed before validating signatures in the
thirdwebpackage. It introduces a new function to confirm contract deployment and updates tests to validate the deployment process.Detailed summary
smart-wallet-dev.test.tsto check if a smart account can sign a message after deployment.confirmContractDeploymentfunction to verify that the smart account contract is deployed before proceeding.